[webkit-reviews] review granted: [Bug 224924] [GTK] Add picker UI for <input type=date> and <input type=datetime-local> : [Attachment 428085] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 03:12:41 PDT 2021

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 224924: [GTK] Add picker UI for <input type=date> and <input

Attachment 428085: Patch


--- Comment #9 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 428085
  --> https://bugs.webkit.org/attachment.cgi?id=428085

Patch LGTM, with a small nit to take into account before landing. Thanks!

View in context: https://bugs.webkit.org/attachment.cgi?id=428085&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h:118
> +void webkitWebViewBasePageGrabbedTouch(WebKitWebViewBase*);

Why the change to add the name of the “webkitWebViewBase“ argument
to “webkitWebViewBasePageGrabbedTouch()”? That seems unneeded, please
make sure to only add the prototype for the new function here.

More information about the webkit-reviews mailing list