[webkit-reviews] review granted: [Bug 225576] IPC testing API should have the ability to send and receive shared memory : [Attachment 428113] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 225576: IPC testing API should have the ability to send and receive shared
memory
https://bugs.webkit.org/show_bug.cgi?id=225576

Attachment 428113: Patch

https://bugs.webkit.org/attachment.cgi?id=428113&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 428113
  --> https://bugs.webkit.org/attachment.cgi?id=428113
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428113&action=review

> Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:108
> +    size_t size() { return m_sharedMemory->size(); }

Nit - we can make this method const

> Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:136
> +    RefPtr<SharedMemory> m_sharedMemory;

Nit - I think this can be a `Ref<SharedMemory> m_sharedMemory;`?

> Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:376
> +    return unwrap(JSValueToObject(context, value, 0));

Nit - use nullptr instead of 0?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:294
> +TEST(IPCTestingAPI, CanSendSemaphpre)

Nit - CanSendSemaphore