[webkit-reviews] review granted: [Bug 225446] Don't allow :visited link style in subtrees that use mix-blend-mode : [Attachment 427886] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 8 22:07:17 PDT 2021

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 225446: Don't allow :visited link style in subtrees that use mix-blend-mode

Attachment 427886: patch


--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 427886
  --> https://bugs.webkit.org/attachment.cgi?id=427886

View in context: https://bugs.webkit.org/attachment.cgi?id=427886&action=review

> Source/WebCore/rendering/style/RenderStyle.h:827
> +    void setBlendMode(BlendMode mode)
> +    {
> +	   SET_VAR(m_rareNonInheritedData, effectiveBlendMode,
> +	   SET_VAR(m_rareInheritedData, isInSubtreeWithBlendMode, mode !=
> +    }

I find these multi-line function bodies inside class definitions make it hard
for me to get an overview of what’s in the class. Would you consider moving the
inline function body below the class definition?

More information about the webkit-reviews mailing list