[webkit-reviews] review granted: [Bug 225571] Remove calls to the String::toInt family of functions from JavaScriptCore : [Attachment 428105] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 8 19:16:54 PDT 2021


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 225571: Remove calls to the String::toInt family of functions from
JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=225571

Attachment 428105: Patch

https://bugs.webkit.org/attachment.cgi?id=428105&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 428105
  --> https://bugs.webkit.org/attachment.cgi?id=428105
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review

> Source/JavaScriptCore/ChangeLog:10
> +	   (Inspector::parseLocation): Use
parseIntegerAllowingTrailingJunk<uintptr_t> instead of
> +	   String::toIntPtr.

Why the change from intptr_t to uintptr_t here?


More information about the webkit-reviews mailing list