[webkit-reviews] review granted: [Bug 225373] REGRESSION (r276797?): [ macOS/iOS ] TestWebKitAPI.URLSchemeHandler.Exceptions is flakey crashing : [Attachment 428036] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 225373: REGRESSION (r276797?): [ macOS/iOS ]
TestWebKitAPI.URLSchemeHandler.Exceptions is flakey crashing
https://bugs.webkit.org/show_bug.cgi?id=225373

Attachment 428036: Patch

https://bugs.webkit.org/attachment.cgi?id=428036&action=review




--- Comment #8 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 428036
  --> https://bugs.webkit.org/attachment.cgi?id=428036
Patch

Seems clearly better, though I am generally confused about why it was
implemented this way, and would like to understand from Brady what the
motivation was.

Also, if this idiom, specifically a RefCounted class as the only member inside
an API::Object, is common, it seems we should try to remove that as I can't see
it serving much purpose.

The idiom of using data structs inside API classes still seems useful, as it
helps to make IPC easier by having a data object to encode/decode.