[webkit-reviews] review granted: [Bug 225494] [macOS] Initialize HLToolbox library before entering sandbox : [Attachment 428054] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 225494: [macOS] Initialize HLToolbox library before entering sandbox
https://bugs.webkit.org/show_bug.cgi?id=225494

Attachment 428054: Patch

https://bugs.webkit.org/attachment.cgi?id=428054&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 428054
  --> https://bugs.webkit.org/attachment.cgi?id=428054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428054&action=review

> Source/WebKit/ChangeLog:18
> +	   If we invoke HLTBIsCurrentProcessBackgroundOnly() at launch, we can
complete our LaunchServices communications prior
> +	   to cutting them off as we enter the sandbox. HLToolbox caches the
result, so will perform properly for the rest of
> +	   the WebContent process runtime.

This comment does not clarify that calling GetGrayRgn does this.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:689
> +    // Cache background state for HLToolBox so AppKit doesn't try to talk to
LaunchServices after we enter the sandbox

WebKit style caller for a period at the end of the sentence.

Change log comment calls this HLToolbox but this comment calls it HLToolBox.

Comment does not make it clear why calling GetGrayRgn accomplishes what the
comment says is needed.