[webkit-reviews] review granted: [Bug 225548] [GPUP] A small video element enters fullscreen with strange animations : [Attachment 428066] Fix build failures (again)

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 225548: [GPUP] A small video element enters fullscreen with strange
animations
https://bugs.webkit.org/show_bug.cgi?id=225548

Attachment 428066: Fix build failures (again)

https://bugs.webkit.org/attachment.cgi?id=428066&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 428066
  --> https://bugs.webkit.org/attachment.cgi?id=428066
Fix build failures (again)

View in context: https://bugs.webkit.org/attachment.cgi?id=428066&action=review

> Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:100
> +	   bool inFullscreenOrPictureInPicture = false;
> +	   if (auto* mediaPlayerPrivateRemote = self.mediaPlayerPrivateRemote)
> +	       inFullscreenOrPictureInPicture =
mediaPlayerPrivateRemote->inVideoFullscreenOrPictureInPicture();
> +
> +	   if (inFullscreenOrPictureInPicture) {

Nit: this can be simplified slightly to 

    if (auto* mediaPlayerPrivateRemote = self.mediaPlayerPrivateRemote;
mediaPlayerPrivateRemote &&
mediaPlayerPrivateRemote->inVideoFullscreenOrPictureInPicture())