[webkit-reviews] review granted: [Bug 225535] [JSC] Error#cause must recognize explicit undefined : [Attachment 428057] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 16:47:00 PDT 2021

Alexey Shvayka <shvaikalesh at gmail.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 225535: [JSC] Error#cause must recognize explicit undefined

Attachment 428057: Patch


--- Comment #2 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 428057
  --> https://bugs.webkit.org/attachment.cgi?id=428057

View in context: https://bugs.webkit.org/attachment.cgi?id=428057&action=review

Nice clean-up! r=me with a thought on (micro) optimization.

> Source/JavaScriptCore/runtime/ErrorInstance.cpp:145
> +	       JSValue cause = object->get(globalObject,

We could use slot.isTaintedByOpaqueObject() to avoid this get() if it's
non-observable, like we do in objectConstructorValues() and friends.

More information about the webkit-reviews mailing list