[webkit-reviews] review granted: [Bug 225543] Web Inspector: Breakpoint action add/remove buttons are not vertically aligned with action dropdown : [Attachment 428048] Patch v1.0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 15:46:24 PDT 2021


Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 225543: Web Inspector: Breakpoint action add/remove buttons are not
vertically aligned with action dropdown
https://bugs.webkit.org/show_bug.cgi?id=225543

Attachment 428048: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=428048&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 428048
  --> https://bugs.webkit.org/attachment.cgi?id=428048
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=428048&action=review

r=me with one adjustment

> Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css:32
> +.breakpoint-action-button-container {
> +    padding-block-start: 3px;
> +}

I think we should either make this `5px` and remove the `margin-top: 2px` from
`:matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)`
or do the opposite.


More information about the webkit-reviews mailing list