[webkit-reviews] review granted: [Bug 225541] [iPadOS] Do not present custom input peripherals when switching back to a tab with a focused element : [Attachment 428038] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 15:17:43 PDT 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 225541: [iPadOS] Do not present custom input peripherals when switching
back to a tab with a focused element
https://bugs.webkit.org/show_bug.cgi?id=225541

Attachment 428038: Patch

https://bugs.webkit.org/attachment.cgi?id=428038&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 428038
  --> https://bugs.webkit.org/attachment.cgi?id=428038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428038&action=review

> LayoutTests/fast/forms/ios/focus-select-and-switch-tabs.html:35
> +    await UIHelper.delayFor(2000);

Nit - though an arbitrary time for a test like this is fine, 2 seconds seems a
tad excessive…

Does it still reliably fail (without the fix) if we bring it down to say, 500
ms?


More information about the webkit-reviews mailing list