[webkit-reviews] review granted: [Bug 224389] Add support for a `media` attribute on `<meta name="theme-color" content="...">` : [Attachment 427323] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 224389: Add support for a `media` attribute on `<meta name="theme-color"
content="...">`
https://bugs.webkit.org/show_bug.cgi?id=224389

Attachment 427323: Patch

https://bugs.webkit.org/attachment.cgi?id=427323&action=review




--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 427323
  --> https://bugs.webkit.org/attachment.cgi?id=427323
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427323&action=review

> Source/WebCore/html/HTMLMetaElement.cpp:93
> +    // Changing a meta tag while it's not in the tree shouldn't have any
effect on the document.

This comment is unnecessary. It's pretty obvious from the code that's what's
happening.