[webkit-reviews] review granted: [Bug 225433] Web Inspector: Layout panel "Grid Overlays" main checkbox has dead space (no interaction) between checkbox and label text : [Attachment 427941] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 225433: Web Inspector: Layout panel "Grid Overlays" main checkbox has dead
space (no interaction) between checkbox and label text
https://bugs.webkit.org/show_bug.cgi?id=225433

Attachment 427941: Patch

https://bugs.webkit.org/attachment.cgi?id=427941&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 427941
  --> https://bugs.webkit.org/attachment.cgi?id=427941
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427941&action=review

r=me with some minor adjustments

> Source/WebInspectorUI/UserInterface/Views/CSSGridSection.css:69
> +.css-grid-section input[type="checkbox"] {

Can we be more specific about this selector?
```
    .css-grid-section :is(.setting-editor, .node-overlay-list-item-container)
input[type="checkbox"]
```

> Source/WebInspectorUI/UserInterface/Views/CSSGridSection.js:90
> +	   labelInner.append(WI.UIString("Grid Overlays", "Page Overlays @
Layout Sidebar Section Header", "Heading for list of grid nodes"));

`.textContent = `

> Source/WebInspectorUI/UserInterface/Views/SettingEditor.css:31
> +    padding-inline-start: 5px;

This used to also have `5px` of padding on the right too inside
`WI.CSSGridSection`.  Do we not want that anymore?

Also, this is super NIT, but I personally think `4px` looks visually better ��

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css:108
> +.content-view.tab.settings > .settings-view > .container > .editor-group >
.setting-editor input {
>      font-size: inherit;

I feel like we should move more of the generic styles like this to
`Source/WebInspectorUI/UserInterface/Views/SettingEditor.css`.	The only stuff
that should be in this file are the styles that are necessary to make the
Settings Tab look good.