[webkit-reviews] review granted: [Bug 225511] [GStreamer][MediaStream] Emit black frames for disabled video tracks : [Attachment 427995] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 225511: [GStreamer][MediaStream] Emit black frames for disabled video
tracks
https://bugs.webkit.org/show_bug.cgi?id=225511

Attachment 427995: Patch

https://bugs.webkit.org/attachment.cgi?id=427995&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 427995
  --> https://bugs.webkit.org/attachment.cgi?id=427995
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427995&action=review

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:27
6
> +	   pushSample(blackSample.get());

Nit (maybe for other time): wouldn't it be nice pushSample was void
pushSample(GRefPtr<GstSample>&&) ?