[webkit-reviews] review granted: [Bug 225505] Allow libwebrtc to build for Mac Catalyst : [Attachment 427973] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 225505: Allow libwebrtc to build for Mac Catalyst
https://bugs.webkit.org/show_bug.cgi?id=225505

Attachment 427973: Patch

https://bugs.webkit.org/attachment.cgi?id=427973&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 427973
  --> https://bugs.webkit.org/attachment.cgi?id=427973
Patch

Nice!

View in context: https://bugs.webkit.org/attachment.cgi?id=427973&action=review

>
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vp8
_rtcd.h:658
> +#ifndef WK_MAC_CATALYST

Hum, maybe I should change WEBRTC_WEBKIT_BUILD to WK_BUILD?
Or maybe we should change here to WEBRTC_WEBKIT_MAC_CATALIST

>
Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vp9
_rtcd.h:518
> +#if !defined(WK_DISABLE_HARDWARE_ACCELERATION) && !defined(WK_MAC_CATALYST)

And change to WEBRTC_WEBKIT_DISABLE_HARDWARE_ACCELERATION