[webkit-reviews] review granted: [Bug 225362] Port Filesystem::fileMetadata() & Filesystem::getFileModificationTime() to std::filesystem : [Attachment 427916] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 225362: Port Filesystem::fileMetadata() &
Filesystem::getFileModificationTime() to std::filesystem
https://bugs.webkit.org/show_bug.cgi?id=225362

Attachment 427916: Patch

https://bugs.webkit.org/attachment.cgi?id=427916&action=review




--- Comment #34 from Darin Adler <darin at apple.com> ---
Comment on attachment 427916
  --> https://bugs.webkit.org/attachment.cgi?id=427916
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427916&action=review

> LayoutTests/ChangeLog:8
> +	   Stop testing the size of a directory in the data transfer API as the
result is implementation-specific.

I understand that this test wasn’t a good way to test the value of size. But is
it right to just stop testing it at all? How can we best make sure it keeps
working properly?