[webkit-reviews] review granted: [Bug 225478] Fix crash when WebsiteDataStore is destroyed with outstanding getNetworkProcessConnection request : [Attachment 427926] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 225478: Fix crash when WebsiteDataStore is destroyed with outstanding
getNetworkProcessConnection request
https://bugs.webkit.org/show_bug.cgi?id=225478

Attachment 427926: Patch

https://bugs.webkit.org/attachment.cgi?id=427926&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 427926
  --> https://bugs.webkit.org/attachment.cgi?id=427926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427926&action=review

r=me

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1725
> +	       RunLoop::main().dispatch([weakThis = WTFMove(weakThis),
webProcessProxy = WTFMove(webProcessProxy), reply = WTFMove(reply)] () mutable
{

We may want to add a comment explaining we're retrying asynchronously because
we may be in the middle of destruction.