[webkit-reviews] review granted: [Bug 225409] [iOS] UI process hangs when showing a modal JavaScript dialog while focusing an input field : [Attachment 427836] More minor adjustments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 225409: [iOS] UI process hangs when showing a modal JavaScript dialog while
focusing an input field
https://bugs.webkit.org/show_bug.cgi?id=225409

Attachment 427836: More minor adjustments

https://bugs.webkit.org/attachment.cgi?id=427836&action=review




--- Comment #19 from Darin Adler <darin at apple.com> ---
Comment on attachment 427836
  --> https://bugs.webkit.org/attachment.cgi?id=427836
More minor adjustments

View in context: https://bugs.webkit.org/attachment.cgi?id=427836&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:5725
> +    runModalJavaScriptDialog(WTFMove(frame), WTFMove(frameInfo), message,
[weakThis = makeWeakPtr(*this), reply = WTFMove(reply)](WebPageProxy& page,
WebFrameProxy* frame, FrameInfoData&& frameInfo, const String& message,
CompletionHandler<void()>&& completion) mutable {

Still unnecessarily capturing weakThis here. Should delete that.

> Source/WebKit/UIProcess/WebPageProxy.cpp:5748
> +    runModalJavaScriptDialog(WTFMove(frame), WTFMove(frameInfo), message,
[weakThis = makeWeakPtr(*this), reply = WTFMove(reply)](WebPageProxy& page,
WebFrameProxy* frame, FrameInfoData&& frameInfo, const String& message,
CompletionHandler<void()>&& completion) mutable {

Ditto.

> Source/WebKit/UIProcess/WebPageProxy.cpp:5771
> +    runModalJavaScriptDialog(WTFMove(frame), WTFMove(frameInfo), message,
[weakThis = makeWeakPtr(*this), reply = WTFMove(reply),
defaultValue](WebPageProxy& page, WebFrameProxy* frame, FrameInfoData&&
frameInfo, const String& message, CompletionHandler<void()>&& completion)
mutable {

Ditto.