[webkit-reviews] review denied: [Bug 214291] [css-writing-modes] New failures on WPT ref-tests after updating WPT import : [Attachment 427532] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 214291: [css-writing-modes] New failures on WPT ref-tests after updating
WPT import
https://bugs.webkit.org/show_bug.cgi?id=214291

Attachment 427532: Patch

https://bugs.webkit.org/attachment.cgi?id=427532&action=review




--- Comment #9 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 427532
  --> https://bugs.webkit.org/attachment.cgi?id=427532
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427532&action=review

> Source/WebCore/dom/Element.cpp:3502
> +    const RenderStyle* style = nullptr;
> +    if (allowRenderStyle == AllowRenderStyle::No &&
document().documentElement() == this) {
> +	   if (hasRareData())
> +	       style = elementRareData()->computedStyle();
> +	   if (!style)
> +	       setNodeFlag(NodeFlag::IsComputedStyleInvalidFlag);
> +    } else
> +	   style = existingComputedStyle();

It is deeply wrong to insert this sort of hack into our core code to paper over
a minor test failure. 

Pretty sure the actual issue here is not properly understood.