[webkit-reviews] review granted: [Bug 221742] REGRESSION (r272414?): [macOS] TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo is a flaky failure : [Attachment 427803] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 221742: REGRESSION (r272414?): [macOS]
TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=221742

Attachment 427803: Patch

https://bugs.webkit.org/attachment.cgi?id=427803&action=review




--- Comment #12 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 427803
  --> https://bugs.webkit.org/attachment.cgi?id=427803
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427803&action=review

> Tools/ChangeLog:10
> +	   relying on [webView _isPlayingAudio]. Also use a test page with a
single video element instead

Does this uncover a potential issue with _isPlayingAudio in case of crash?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:320
> +    [webView
objectByEvaluatingJavaScriptWithUserGesture:@"document.getElementsByTagName('vi
deo')[0].play() && true"];

Why not just doing @"play()"?