[webkit-reviews] review granted: [Bug 225424] DisplayList::Recorder::canAppendItemOfType shouldn't be responsible for appending context state change items : [Attachment 427824] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Cameron McCormack
(:heycam) <heycam at apple.com>'s request for review:
Bug 225424: DisplayList::Recorder::canAppendItemOfType shouldn't be responsible
for appending context state change items
https://bugs.webkit.org/show_bug.cgi?id=225424

Attachment 427824: Patch

https://bugs.webkit.org/attachment.cgi?id=427824&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 427824
  --> https://bugs.webkit.org/attachment.cgi?id=427824
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427824&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:124
>  bool Recorder::canAppendItemOfType(ItemType type)

This function can now be const.

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:129
> +void Recorder::appendStateChangeItemIfStateHasChanged()

Usually we say "IfNecessary"

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:131
> +    GraphicsContextStateChange& stateChanges = currentState().stateChange;

auto&

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:132
> +    GraphicsContextState::StateChangeFlags changesFromLastState =
stateChanges.changesFromState(currentState().lastDrawingState);

auto