[webkit-reviews] review granted: [Bug 225221] [run-api-tests] Use webkitcorepy's TaskPool : [Attachment 427816] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 225221: [run-api-tests] Use webkitcorepy's TaskPool
https://bugs.webkit.org/show_bug.cgi?id=225221

Attachment 427816: Patch

https://bugs.webkit.org/attachment.cgi?id=427816&action=review




--- Comment #8 from dewei_zhu at apple.com ---
Comment on attachment 427816
  --> https://bugs.webkit.org/attachment.cgi?id=427816
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427816&action=review

r=me

> Tools/ChangeLog:18
> +	   (_Worker.setup): Pass port object to worker process.
> +	   (_Worker.setup): Pass port object to worker process.

Nit: those two lines are identical, we only need one, right?

> Tools/Scripts/webkitpy/api_tests/runner.py:118
> +	       Runner.instance = self

Discussed in person, let's add an assertion that `Runner.instance is None`
before this assignment.