[webkit-reviews] review granted: [Bug 225409] [iOS] UI process hangs when showing a modal JavaScript dialog while focusing an input field : [Attachment 427805] For EWS

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 225409: [iOS] UI process hangs when showing a modal JavaScript dialog while
focusing an input field
https://bugs.webkit.org/show_bug.cgi?id=225409

Attachment 427805: For EWS

https://bugs.webkit.org/attachment.cgi?id=427805&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 427805
  --> https://bugs.webkit.org/attachment.cgi?id=427805
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=427805&action=review

> Source/WebKit/ChangeLog:37
> +	   Make a slight adjustment here so that `waitForMessage` bails if one
of the messages we're dispatching underneath
> +	   `SyncMessageState::dispatchMessages` is the message we happen to be
waiting for anyways. In this case, it's
> +	   necessary in order for the preemptive
`WebPageProxy::HandleAutocorrectionContext` message sent by the web
> +	   process to unblock the UI process, which is waiting for a
`WebPageProxy::HandleAutocorrectionContext` response.

This part could use a careful Chris review, but does not seem outrageous (once
Wenson explained to me that MessageName is now unique across receivers, which I
missed).