[webkit-reviews] review granted: [Bug 225410] Forbid further execution in jsc shell if execution is terminated. : [Attachment 427797] propose patch.

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 225410: Forbid further execution in jsc shell if execution is terminated.
https://bugs.webkit.org/show_bug.cgi?id=225410

Attachment 427797: propose patch.

https://bugs.webkit.org/attachment.cgi?id=427797&action=review




--- Comment #2 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 427797
  --> https://bugs.webkit.org/attachment.cgi?id=427797
propose patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=427797&action=review

r=me with a suggested change.

> Source/JavaScriptCore/runtime/VM.h:345
> +    void setExecutionForbidden(bool value) { m_executionForbidden = value; }

Seem like we only want to go from "execution allowed", e.g.
m_executionForbidden == false, to "execution forbidden", e.g.
m_executionForbidden == true.  I suggest we eliminate the argument to
setExecutionForbidden() and have it always set m_executionForbidden to true.