[webkit-reviews] review granted: [Bug 225395] AppHighlight scrolls should be smooth : [Attachment 427789] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 225395: AppHighlight scrolls should be smooth
https://bugs.webkit.org/show_bug.cgi?id=225395

Attachment 427789: Patch

https://bugs.webkit.org/attachment.cgi?id=427789&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 427789
  --> https://bugs.webkit.org/attachment.cgi?id=427789
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427789&action=review

> Source/WebCore/page/ScrollBehavior.cpp:53
> +	   if
(!associatedElement->document().settings().CSSOMViewSmoothScrollingEnabled())
> +	       return false;

This seems *right*, but it is confusing. You're using the passed-in behavior
unconditionally, unless it's auto, in which case you use the element's style's
behavior only if the bit is on, right? And then making sure that script doesn't
pass smooth if the setting is off at that callsite? I think it's OK. Maybe want
smfr to peek.