[webkit-reviews] review granted: [Bug 224326] [css-scroll-snap] Compute proximity information while snapping : [Attachment 425591] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 224326: [css-scroll-snap] Compute proximity information while snapping
https://bugs.webkit.org/show_bug.cgi?id=224326

Attachment 425591: Patch

https://bugs.webkit.org/attachment.cgi?id=425591&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 425591
  --> https://bugs.webkit.org/attachment.cgi?id=425591
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425591&action=review

>
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateI
OS.mm:109
> +    WebCore::FloatSize
viewportSize(static_cast<float>(CGRectGetWidth([scrollView bounds])),
static_cast<float>(CGRectGetHeight([scrollView bounds])));

I think you can construct a FloatSize from a CGSize, so this could be
WebCore::FloatSize viewportSize = [scrollView bounds].size;