[webkit-reviews] review granted: [Bug 194332] CSS custom properties on pseudo elements background gradients causes infinite layout and high CPU load : [Attachment 427763] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 194332: CSS custom properties on pseudo elements background gradients
causes infinite layout and high CPU load
https://bugs.webkit.org/show_bug.cgi?id=194332

Attachment 427763: Patch

https://bugs.webkit.org/attachment.cgi?id=427763&action=review




--- Comment #16 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 427763
  --> https://bugs.webkit.org/attachment.cgi?id=427763
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427763&action=review

> Source/WebCore/rendering/style/FillLayer.cpp:406
>      for (; layer1 && layer2; layer1 = layer1->next(), layer2 =
layer2->next()) {
> -	   if (!arePointingToEqualData(layer1->image(), layer2->image()))
> +	   if (layer1->image() != layer2->image())
>	       return false;

You should also rename imagesIdentical to something that reflects its only call
site, imageChangeRequiresClientReregistration or something.