[webkit-reviews] review granted: [Bug 221982] Add support for syncing repo with commit revision label : [Attachment 427728] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 4 23:13:06 PDT 2021


Ryosuke Niwa <rniwa at webkit.org> has granted Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 221982: Add support for syncing repo with commit revision label
https://bugs.webkit.org/show_bug.cgi?id=221982

Attachment 427728: Patch

https://bugs.webkit.org/attachment.cgi?id=427728&action=review




--- Comment #56 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 427728
  --> https://bugs.webkit.org/attachment.cgi?id=427728
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427728&action=review

> Websites/perf.webkit.org/tools/sync-commits.py:258
> +		   raise ValueError('Expected commit message to include
revision identifier, but cannot find it, will need a history rewrite to fix
it')

Ugh... sorry, I keep noticing new issues. Please see my earlier comment about
revising this message.


More information about the webkit-reviews mailing list