[webkit-reviews] review denied: [Bug 221982] Add support for syncing repo with commit revision label : [Attachment 427715] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 4 18:52:36 PDT 2021


Ryosuke Niwa <rniwa at webkit.org> has denied Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 221982: Add support for syncing repo with commit revision label
https://bugs.webkit.org/show_bug.cgi?id=221982

Attachment 427715: Patch

https://bugs.webkit.org/attachment.cgi?id=427715&action=review




--- Comment #49 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 427715
  --> https://bugs.webkit.org/attachment.cgi?id=427715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427715&action=review

> Websites/perf.webkit.org/tools/sync-commits.py:217
> +		   # translate the last svn revision to git hash

This comment should be either removed or the following code should be extracted
as a helper method.
r- because of this.


More information about the webkit-reviews mailing list