[webkit-reviews] review granted: [Bug 224678] Web Inspector: add assertion for `WI.View` re-entrancy : [Attachment 427630] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 4 10:25:28 PDT 2021

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 224678: Web Inspector: add assertion for `WI.View` re-entrancy

Attachment 427630: Patch


--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 427630
  --> https://bugs.webkit.org/attachment.cgi?id=427630

View in context: https://bugs.webkit.org/attachment.cgi?id=427630&action=review

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:1789
> +WI.setReentrantCheck = function(object, key) {

Is this style normally to put opening brace on the following line? I'm fine
either way.

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:1797
> +    --object[key];

Might read better as the `(object[key] || 0) - 1` in case the key doesn't

>>> --({}['x'])

More information about the webkit-reviews mailing list