[webkit-reviews] review granted: [Bug 217535] [Media in GPU Process] Move AudioSessionRoutingArbitratorProxy to the GPU process : [Attachment 424181] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 217535: [Media in GPU Process] Move AudioSessionRoutingArbitratorProxy to
the GPU process
https://bugs.webkit.org/show_bug.cgi?id=217535

Attachment 424181: Patch

https://bugs.webkit.org/attachment.cgi?id=424181&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 424181
  --> https://bugs.webkit.org/attachment.cgi?id=424181
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424181&action=review

r=me once the bots are happy

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:204
> +    , m_routingArbitrator(LocalAudioSessionRoutingArbitrator::create())

Is it possible to create this lazily?

> Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.cpp:57
> +    m_arbitrationUpdateTime = WallTime::now();

MonotonicTime?

> Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.h:54
> +    WallTime arbitrationUpdateTime() const { return m_arbitrationUpdateTime;
}

Ditto.