[webkit-reviews] review granted: [Bug 225286] Add preliminary support for specifying a color space for 2D canvas : [Attachment 427674] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 225286: Add preliminary support for specifying a color space for 2D canvas
https://bugs.webkit.org/show_bug.cgi?id=225286

Attachment 427674: Patch

https://bugs.webkit.org/attachment.cgi?id=427674&action=review




--- Comment #7 from Dean Jackson <dino at apple.com> ---
Comment on attachment 427674
  --> https://bugs.webkit.org/attachment.cgi?id=427674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427674&action=review

>
LayoutTests/fast/canvas/CanvasRenderingContext2DSettings-colorSpace-disabled.ht
ml:11
> +	   let canvas = document.createElement("canvas");
> +	   let context = canvas.getContext("2d", settings);

Nit: const
(and elsewhere)

> LayoutTests/fast/canvas/canvas-color-space-display-p3.html:5
> +    <p>This test passes if the square below looks to be all one color</p>

Nice test!