[webkit-reviews] review granted: [Bug 225319] Dynamically pass capture sandbox extensions to GPUProcess : [Attachment 427647] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 225319: Dynamically pass capture sandbox extensions to GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=225319

Attachment 427647: Patch

https://bugs.webkit.org/attachment.cgi?id=427647&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 427647
  --> https://bugs.webkit.org/attachment.cgi?id=427647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427647&action=review

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:190
> +	      
SandboxExtension::createHandleForMachLookup("com.apple.applecamerad"_s,
WTF::nullopt, appleCameraServicePathSandboxExtensionHandle);
> +	      
extensions.append(WTFMove(appleCameraServicePathSandboxExtensionHandle));
> +#if HAVE(ADDITIONAL_APPLE_CAMERA_SERVICE)
> +	       SandboxExtension::Handle
additionalAppleCameraServicePathSandboxExtensionHandle;
> +	      
SandboxExtension::createHandleForMachLookup("com.apple.appleh13camerad"_s,
WTF::nullopt, additionalAppleCameraServicePathSandboxExtensionHandle);

It would be good to release log and not set `m_hasSentCameraSandboxExtension`
if we can't create either of these like we do for "com.apple.webkit.camera".