[webkit-reviews] review denied: [Bug 225336] Inclusive terminology: Change 'master key' to 'main key' : [Attachment 427618] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 3 17:31:48 PDT 2021


Brent Fulgham <bfulgham at webkit.org> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 225336: Inclusive terminology: Change 'master key' to 'main key'
https://bugs.webkit.org/show_bug.cgi?id=225336

Attachment 427618: Patch

https://bugs.webkit.org/attachment.cgi?id=427618&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 427618
  --> https://bugs.webkit.org/attachment.cgi?id=427618
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427618&action=review

>> Source/WebCore/ChangeLog:9
>> +	    Change the text 'Master Key' to 'Main Key' in messages and labels.
> 
> Will this invalidate all data encrypted with this key? What exactly will the
user impact be?

I don't think this will invalidate the key data, but looking further it does
seem like we would lose access to the existing keychain, so we probably need a
migration step.


More information about the webkit-reviews mailing list