[webkit-reviews] review granted: [Bug 225276] Allow AppHighlight visibility to be toggled : [Attachment 427611] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 3 17:22:30 PDT 2021

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 225276: Allow AppHighlight visibility to be toggled

Attachment 427611: Patch


--- Comment #10 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 427611
  --> https://bugs.webkit.org/attachment.cgi?id=427611

View in context: https://bugs.webkit.org/attachment.cgi?id=427611&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:7529
> +	   if (auto* document = frame->document())

This should be protected with a RefPtr, like so:

auto document = makeRefPtr(frame->document())

More information about the webkit-reviews mailing list