[webkit-reviews] review requested: [Bug 212952] Remove "no-preference" value for prefers-color-scheme media query : [Attachment 427530] Patch

[bugzilla-daemon at webkit.org]

Tim Nguyen (:ntim) <ntim at apple.com> has asked  for review:
Bug 212952: Remove "no-preference" value for prefers-color-scheme media query
https://bugs.webkit.org/show_bug.cgi?id=212952

Attachment 427530: Patch

https://bugs.webkit.org/attachment.cgi?id=427530&action=review




--- Comment #5 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 427530
  --> https://bugs.webkit.org/attachment.cgi?id=427530
Patch

Regarding tests: the test already tests for `foo` which is the invalid keyword
case (like `no-preference`). WPT also has coverage for `no-preference`:
https://wpt.fyi/results/css/mediaqueries/prefers-color-scheme.html?label=master
&label=experimental&aligned&q=prefers-color-scheme

Regarding removing all the code: CSSValueNoPreference can't be removed since
other MQ use it (prefers-contrast/prefers-reduced-motion).