[webkit-reviews] review requested: [Bug 212952] Remove "no-preference" value for prefers-color-scheme media query : [Attachment 427530] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 3 01:15:12 PDT 2021

Tim Nguyen (:ntim) <ntim at apple.com> has asked  for review:
Bug 212952: Remove "no-preference" value for prefers-color-scheme media query

Attachment 427530: Patch


--- Comment #5 from Tim Nguyen (:ntim) <ntim at apple.com> ---
Comment on attachment 427530
  --> https://bugs.webkit.org/attachment.cgi?id=427530

Regarding tests: the test already tests for `foo` which is the invalid keyword
case (like `no-preference`). WPT also has coverage for `no-preference`:

Regarding removing all the code: CSSValueNoPreference can't be removed since
other MQ use it (prefers-contrast/prefers-reduced-motion).

More information about the webkit-reviews mailing list