[webkit-reviews] review granted: [Bug 225272] Move PixelFormat into its own file : [Attachment 427505] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 1 20:10:01 PDT 2021


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 225272: Move PixelFormat into its own file
https://bugs.webkit.org/show_bug.cgi?id=225272

Attachment 427505: Patch

https://bugs.webkit.org/attachment.cgi?id=427505&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 427505
  --> https://bugs.webkit.org/attachment.cgi?id=427505
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427505&action=review

> Source/WebCore/platform/graphics/PixelFormat.h:37
> +enum class PixelFormat : uint8_t {
> +    RGBA8,
> +    BGRA8,
> +    RGB10,
> +    RGB10A8,
> +};

When there is a short list like that, I love to do it horizontally instead of
vertically, but not sure you feel the same.


More information about the webkit-reviews mailing list