[webkit-reviews] review granted: [Bug 225251] Use SortedArrayMap in a few more places : [Attachment 427469] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 225251: Use SortedArrayMap in a few more places
https://bugs.webkit.org/show_bug.cgi?id=225251

Attachment 427469: Patch

https://bugs.webkit.org/attachment.cgi?id=427469&action=review




--- Comment #6 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 427469
  --> https://bugs.webkit.org/attachment.cgi?id=427469
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427469&action=review

> Source/WebCore/dom/ScriptElement.cpp:112
> +    static constexpr ComparableLettersLiteral languageArray[] = {

This is not new to this change, but I think it is a little harder to understand
that this will be a case-folded comparison (at least, I think that is what
ComparableLettersLiteral does) as opposed to HashSet<String,
ASCIICaseInsensitiveHash> which really sold it.