[webkit-reviews] review granted: [Bug 224030] Clear network website data when a user clears history/website data : [Attachment 424851] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 31 19:24:15 PDT 2021
Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 224030: Clear network website data when a user clears history/website data
https://bugs.webkit.org/show_bug.cgi?id=224030
Attachment 424851: Patch
https://bugs.webkit.org/attachment.cgi?id=424851&action=review
--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 424851
--> https://bugs.webkit.org/attachment.cgi?id=424851
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=424851&action=review
r=me, but please double-check with David for the SOFT_LINK stuff.
> Source/WTF/wtf/cocoa/SoftLinking.h:120
> +#define SOFT_LINK_PRIVATE_FRAMEWORK_IN_UMBRELLA(umbrella, framework) \
I'd suggest getting David's r+ on this. I can never remember when you need the
_SOURCE version of these macros. Looks good to me though.
More information about the webkit-reviews
mailing list