[webkit-reviews] review granted: [Bug 223997] Make FontCache constructable and safe to use off the main thread : [Attachment 424834] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Lord <clord at igalia.com>'s
request for review:
Bug 223997: Make FontCache constructable and safe to use off the main thread
https://bugs.webkit.org/show_bug.cgi?id=223997

Attachment 424834: Patch

https://bugs.webkit.org/attachment.cgi?id=424834&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 424834
  --> https://bugs.webkit.org/attachment.cgi?id=424834
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424834&action=review

> Source/WebCore/platform/graphics/FontCache.h:41
> +#include <wtf/RefCounted.h>

Should not need this if the header is including WTFString.h or AtomString.h

> Source/WebCore/platform/graphics/FontCascadeFonts.cpp:491
> +    ASSERT(m_thread.ptr() == &Thread::current());

Not sure this does the right thing with the web thread on iOS.

> Source/WebCore/platform/graphics/FontCascadeFonts.h:117
> +    Ref<Thread> m_thread { Thread::current() };

Should wrap this in #if ASSERT_ENABLED.

> Source/WebCore/platform/graphics/FontCascadeFonts.h:129
> +    ASSERT(m_thread.ptr() == &Thread::current());

Not sure this does the right thing with the web thread on iOS.