[webkit-reviews] review granted: [Bug 223958] Web Inspector: [Cocoa] WKInspectorResourceURLSchemeHandler can exceed the soft thread limit when opening multiple inspectors simultaneously. : [Attachment 424701] Patch v1.0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 31 15:30:28 PDT 2021


BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 223958: Web Inspector: [Cocoa] WKInspectorResourceURLSchemeHandler can
exceed the soft thread limit when opening multiple inspectors simultaneously.
https://bugs.webkit.org/show_bug.cgi?id=223958

Attachment 424701: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=424701&action=review




--- Comment #3 from BJ Burg <bburg at apple.com> ---
Comment on attachment 424701
  --> https://bugs.webkit.org/attachment.cgi?id=424701
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=424701&action=review

r=me

>
Source/WebKit/UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.mm:62
> +	   // The default value
(NSOperationQueueDefaultMaxConcurrentOperationCount) results in a large number
of threads

I think this second comment is nice but redundant with the changelog, and could
be removed.


More information about the webkit-reviews mailing list