[webkit-reviews] review granted: [Bug 224019] List of extents should be bounds-checked when iterating display list items : [Attachment 424828] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 31 15:21:55 PDT 2021
Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 224019: List of extents should be bounds-checked when iterating display
list items
https://bugs.webkit.org/show_bug.cgi?id=224019
Attachment 424828: Patch
https://bugs.webkit.org/attachment.cgi?id=424828&action=review
--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 424828
--> https://bugs.webkit.org/attachment.cgi?id=424828
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=424828&action=review
> Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:135
> - EXPECT_EQ(result.reasonForStopping, StopReplayReason::InvalidItem);
> + EXPECT_EQ(result.reasonForStopping,
StopReplayReason::InvalidItemOrExtent);
Neither of these tests the extent validation, right? Is it possible to write a
test?
More information about the webkit-reviews
mailing list