[webkit-reviews] review granted: [Bug 224012] Move AnimationTimeline methods related to Styleable to Styleable : [Attachment 424807] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 31 14:46:05 PDT 2021


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 224012: Move AnimationTimeline methods related to Styleable to Styleable
https://bugs.webkit.org/show_bug.cgi?id=224012

Attachment 424807: Patch

https://bugs.webkit.org/attachment.cgi?id=424807&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 424807
  --> https://bugs.webkit.org/attachment.cgi?id=424807
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424807&action=review

> Source/WebCore/ChangeLog:21
> +	   These really belong on Styleable so we move them all over to that
class with a new .cpp class
> +	   for these non-trivial methods.

Stylable is a pretty generic name, but all these functions are related to
animations. Maybe this should be called something like AnimatableStyleable?


More information about the webkit-reviews mailing list