[webkit-reviews] review granted: [Bug 223984] Assertions in DisplayUpdate when dragging WebView windows between screens with different refresh rates : [Attachment 424734] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 31 11:24:29 PDT 2021


Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 223984: Assertions in DisplayUpdate when dragging WebView windows between
screens with different refresh rates
https://bugs.webkit.org/show_bug.cgi?id=223984

Attachment 424734: Patch

https://bugs.webkit.org/attachment.cgi?id=424734&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 424734
  --> https://bugs.webkit.org/attachment.cgi?id=424734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424734&action=review

> Source/WebCore/page/Chrome.cpp:549
> +void Chrome::windowScreenDidChange(PlatformDisplayID displayID,
Optional<FramesPerSecond> nominalFrameInterval)

Seems like at some point we should add a "PlatformDisplay" or "PlatformScreen"
object that can package these.

> Source/WebCore/page/Page.cpp:1186
> +	   // If the caller didn't give us a refresh rate, maybe the relevant
DisplayRefreshMonitor can? This happens in WebKitLegacy.

Can you add a little bit more detail about why this can happen in WebKitLegacy?


More information about the webkit-reviews mailing list