[webkit-reviews] review granted: [Bug 223995] Make FontCache self-contained (remove static global variables) : [Attachment 424762] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Lord <clord at igalia.com>'s
request for review:
Bug 223995: Make FontCache self-contained (remove static global variables)
https://bugs.webkit.org/show_bug.cgi?id=223995

Attachment 424762: Patch

https://bugs.webkit.org/attachment.cgi?id=424762&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 424762
  --> https://bugs.webkit.org/attachment.cgi?id=424762
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424762&action=review

> Source/WebCore/platform/graphics/FontCache.h:299
> +    struct FontPlatformDataCacheKey {

If we want to keep this all out of the header, we can put these things into a
structure in a WTF::UniqueRef instead of directly into the FontCache object
itself. Uses a little more memory, but helps keep the FontCache.h file smaller.