[webkit-reviews] review granted: [Bug 223598] Use Element for checking Settings in CSSComputedStyleDeclaration : [Attachment 424343] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 31 09:24:07 PDT 2021


Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 223598: Use Element for checking Settings in CSSComputedStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=223598

Attachment 424343: Patch

https://bugs.webkit.org/attachment.cgi?id=424343&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 424343
  --> https://bugs.webkit.org/attachment.cgi?id=424343
Patch

8 changes, but only 2 tests; I’d expect we’d need 8 different tests to cover
them all. Also, did these tests fail before making the change?


More information about the webkit-reviews mailing list