[webkit-reviews] review granted: [Bug 223988] WebGL conformance tests are missing files due to too widely matching .gitignore : [Attachment 424742] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 223988: WebGL conformance tests are missing files due to too widely
matching .gitignore
https://bugs.webkit.org/show_bug.cgi?id=223988

Attachment 424742: Patch

https://bugs.webkit.org/attachment.cgi?id=424742&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 424742
  --> https://bugs.webkit.org/attachment.cgi?id=424742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424742&action=review

> .gitignore:7
>  .directory
> -build/
> -!/PerformanceTests/Speedometer/**/build/
> +/build/

This also makes `build` directories under
Websites/browserbench.org/Speedometer2.0 ignored. I'm not 100% certain, but in
the case of Websites folder, that may be wrong. Can you confirm with Ryosuke
before landing?

In fact, it's not even clear to me why `build` directories under
PerformanceTests are ignored, as there is checked in content there.