[webkit-reviews] review granted: [Bug 216851] Missing scope release in JSDOMBuiltinConstructorBase : [Attachment 424644] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 30 18:23:04 PDT 2021


Ryosuke Niwa <rniwa at webkit.org> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 216851: Missing scope release in JSDOMBuiltinConstructorBase
https://bugs.webkit.org/show_bug.cgi?id=216851

Attachment 424644: Patch

https://bugs.webkit.org/attachment.cgi?id=424644&action=review




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 424644
  --> https://bugs.webkit.org/attachment.cgi?id=424644
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424644&action=review

> LayoutTests/ChangeLog:9
> +	   * js/script-tests/transform-stream.js: Added.

Can we just inline this into transform-stream.html?

> LayoutTests/js/dom/script-tests/transform-stream.js:3
> +description(
> +"Tests exception checking in
JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments."
> +);

Maybe put ( ~ ) in a single line?


More information about the webkit-reviews mailing list