[webkit-reviews] review granted: [Bug 223959] Add Options::exitOnResourceExhaustion() to enable exiting instead of crashing on resource exhaustion. : [Attachment 424704] proposed patch.

[bugzilla-daemon at webkit.org]

Tadeu Zagallo <tzagallo at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 223959: Add Options::exitOnResourceExhaustion() to enable exiting instead
of crashing on resource exhaustion.
https://bugs.webkit.org/show_bug.cgi?id=223959

Attachment 424704: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=424704&action=review




--- Comment #2 from Tadeu Zagallo <tzagallo at apple.com> ---
Comment on attachment 424704
  --> https://bugs.webkit.org/attachment.cgi?id=424704
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=424704&action=review

r=me

> Source/JavaScriptCore/runtime/ResourceExhaustion.cpp:36
> +    WTFReportAssertionFailureWithMessage(file, line, function, assertion,
"ResourceExhaustion(%d): %s", static_cast<int>(exitCode), failureMessage);

Since this isn't called directly, you could use the macro to stringify the
ResourceExhaustionCode.