[webkit-reviews] review granted: [Bug 222930] Web Inspector: Regression (r270134) Timeline recordings 2 and beyond do not show a timescale. : [Attachment 424610] Patch v1.1 - Revised approach

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 222930: Web Inspector: Regression (r270134) Timeline recordings 2 and
beyond do not show a timescale.
https://bugs.webkit.org/show_bug.cgi?id=222930

Attachment 424610: Patch v1.1 - Revised approach

https://bugs.webkit.org/attachment.cgi?id=424610&action=review




--- Comment #7 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 424610
  --> https://bugs.webkit.org/attachment.cgi?id=424610
Patch v1.1 - Revised approach

View in context: https://bugs.webkit.org/attachment.cgi?id=424610&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:856
> +	   if (this.isAttached)

I wonder if maybe we should also/instead check `this.didInitialLayout` ��

Just a thought.  No need to change it if you'd rather not introduce more
variables :)