[webkit-reviews] review granted: [Bug 223613] JSGlobalObject's m_customGetterFunctionMap and m_customSetterFunctionMap should be sets, not maps, and should use both the identifier and function pointer as the key : [Attachment 424505] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 223613: JSGlobalObject's m_customGetterFunctionMap and
m_customSetterFunctionMap should be sets, not maps, and should use both the
identifier and function pointer as the key
https://bugs.webkit.org/show_bug.cgi?id=223613

Attachment 424505: Patch

https://bugs.webkit.org/attachment.cgi?id=424505&action=review




--- Comment #22 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 424505
  --> https://bugs.webkit.org/attachment.cgi?id=424505
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424505&action=review

Nice. r=me

> Source/JavaScriptCore/runtime/JSObject.cpp:3528
> +    using Key = std::tuple<PropertyName, typename T::CustomFunctionPointer>;

nit: std::pair might be a smidge nicer?

> Source/JavaScriptCore/runtime/WeakGCSet.h:36
> +template<typename T> struct WeakGCSetHashTraits : HashTraits<Weak<T>> {

style nit: Maybe  "template<typename T>" on its own line?

> Source/WTF/ChangeLog:8
> +	   Adds a heterogenous HashSet::ensure, which allows lazy construction
of the value to

nice!